[tryton-commits] changeset in sao:6.4 Test if value is not null before using its ...

[Cédric Krier]

changeset aba68ac3d82c in sao:6.4
details: https://hg.tryton.org/sao?cmd=changeset&node=aba68ac3d82c
description:
        Test if value is not null before using its keys in set_on_change

        issue11497
        review421171003
        (grafted from 3d7c4160bb3852ee7a8e1244090d6fabff5ac457)
diffstat:

 src/model.js |  8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diffs (39 lines):

diff -r 2a19b2ef64c9 -r aba68ac3d82c src/model.js
--- a/src/model.js      Tue May 31 23:49:22 2022 +0200
+++ b/src/model.js      Tue May 31 23:50:48 2022 +0200
@@ -2268,7 +2268,7 @@
                 return this._set_value(record, value, false, true);
             }
             var new_field_names = {};
-            if (value.add || value.update) {
+            if (value && (value.add || value.update)) {
                 var context = this.get_context(record);
                 fields = record._values[this.name].model.fields;
                 var adding_values = [];
@@ -2307,7 +2307,7 @@
             }
 
             var group = record._values[this.name];
-            if (value.delete) {
+            if (value && value.delete) {
                 for (const record_id of value.delete) {
                     const record2 = group.get(record_id);
                     if (record2) {
@@ -2315,7 +2315,7 @@
                     }
                 }
             }
-            if (value.remove) {
+            if (value && value.remove) {
                 for (const record_id of value.remove) {
                     const record2 = group.get(record_id);
                     if (record2) {
@@ -2324,7 +2324,7 @@
                 }
             }
 
-            if (value.add || value.update) {
+            if (value && (value.add || value.update)) {
                 // First set already added fields to prevent triggering a
                 // second on_change call
                 if (value.update) {