changeset e818d2e49488 in modules/sale_subscription:6.0
details: 
https://hg.tryton.org/modules/sale_subscription?cmd=changeset&node=e818d2e49488
description:
        Ensure unique taxes when applying tax rule

        Since issue10841 the taxes must be unique so the tax rule application 
must
        result on unique taxes.

        issue11230
        review415271003
diffstat:

 subscription.py |  8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diffs (28 lines):

diff -r 15a494e2dd96 -r e818d2e49488 subscription.py
--- a/subscription.py   Wed Sep 01 22:54:48 2021 +0200
+++ b/subscription.py   Sun Jul 17 00:02:22 2022 +0200
@@ -939,20 +939,20 @@
                         '.msg_consumption_invoice_missing_account_revenue',
                         product=line.product.rec_name))
 
-            taxes = []
+            taxes = set()
             pattern = line._get_tax_rule_pattern()
             party = invoice.party
             for tax in line.product.customer_taxes_used:
                 if party.customer_tax_rule:
                     tax_ids = party.customer_tax_rule.apply(tax, pattern)
                     if tax_ids:
-                        taxes.extend(tax_ids)
+                        taxes.update(tax_ids)
                     continue
-                taxes.append(tax.id)
+                taxes.add(tax.id)
             if party.customer_tax_rule:
                 tax_ids = party.customer_tax_rule.apply(None, pattern)
                 if tax_ids:
-                    taxes.extend(tax_ids)
+                    taxes.update(tax_ids)
             line.taxes = taxes
 
             lines.append(line)

Reply via email to