details: https://code.tryton.org/tryton/commit/30e74b413c43
branch: default
user: Cédric Krier <[email protected]>
date: Wed Nov 19 12:22:17 2025 +0100
description:
Prevent running create purchase wizard from request with purchase line
Using a button we can prevent to use the wizard on purchase request with
purchase line.
diffstat:
modules/purchase_request/CHANGELOG | 1 +
modules/purchase_request/purchase_request.py | 9 ++++++
modules/purchase_request/purchase_request.xml | 10 +++---
modules/purchase_request/tests/scenario_purchase_request.rst | 16 ++++-------
modules/purchase_request/view/purchase_request_tree.xml | 1 +
5 files changed, 22 insertions(+), 15 deletions(-)
diffs (130 lines):
diff -r 067b9d88952e -r 30e74b413c43 modules/purchase_request/CHANGELOG
--- a/modules/purchase_request/CHANGELOG Sun Mar 17 12:27:03 2024 +0100
+++ b/modules/purchase_request/CHANGELOG Wed Nov 19 12:22:17 2025 +0100
@@ -1,3 +1,4 @@
+* Prevent running create purchase wizard from request with purchase line
* Use the fastest product supplier when anyone can supply on time
Version 7.6.0 - 2025-04-28
diff -r 067b9d88952e -r 30e74b413c43
modules/purchase_request/purchase_request.py
--- a/modules/purchase_request/purchase_request.py Sun Mar 17 12:27:03
2024 +0100
+++ b/modules/purchase_request/purchase_request.py Wed Nov 19 12:22:17
2025 +0100
@@ -116,6 +116,10 @@
where=t.state.in_(['draft', 'purchased', 'exception'])))
cls._order[0] = ('id', 'DESC')
cls._buttons.update({
+ 'create_purchase': {
+ 'invisible': Eval('purchase_line'),
+ 'depends': ['purchase_line'],
+ },
'handle_purchase_cancellation_exception': {
'invisible': Eval('state') != 'exception',
'depends': ['state'],
@@ -331,6 +335,11 @@
return supplier, purchase_date
@classmethod
+ @ModelView.button_action('purchase_request.wizard_create_purchase')
+ def create_purchase(cls, requests):
+ pass
+
+ @classmethod
@ModelView.button_action(
'purchase_request.wizard_purchase_cancellation_handle_exception')
def handle_purchase_cancellation_exception(cls, purchases):
diff -r 067b9d88952e -r 30e74b413c43
modules/purchase_request/purchase_request.xml
--- a/modules/purchase_request/purchase_request.xml Sun Mar 17 12:27:03
2024 +0100
+++ b/modules/purchase_request/purchase_request.xml Wed Nov 19 12:22:17
2025 +0100
@@ -86,7 +86,7 @@
<field
name="name">purchase_request_create_purchase_ask_party_form</field>
</record>
<record model="ir.action.wizard" id="wizard_create_purchase">
- <field name="name">Create Purchase</field>
+ <field name="name">Create Purchases</field>
<field name="wiz_name">purchase.request.create_purchase</field>
<field name="model">purchase.request</field>
</record>
@@ -96,10 +96,10 @@
<field name="group" ref="group_purchase_request"/>
</record>
- <record model="ir.action.keyword" id="create_purchase_keyword">
- <field name="keyword">form_action</field>
- <field name="model">purchase.request,-1</field>
- <field name="action" ref="wizard_create_purchase"/>
+ <record model="ir.model.button"
id="purchase_request_create_purchase_button">
+ <field name="model">purchase.request</field>
+ <field name="name">create_purchase</field>
+ <field name="string">Create Purchases</field>
</record>
<record model="ir.ui.view" id="handle_purchase_cancellation_start">
diff -r 067b9d88952e -r 30e74b413c43
modules/purchase_request/tests/scenario_purchase_request.rst
--- a/modules/purchase_request/tests/scenario_purchase_request.rst Sun Mar
17 12:27:03 2024 +0100
+++ b/modules/purchase_request/tests/scenario_purchase_request.rst Wed Nov
19 12:22:17 2025 +0100
@@ -107,8 +107,7 @@
Create the purchase then cancel it::
- >>> create_purchase = Wizard('purchase.request.create_purchase',
- ... [pr])
+ >>> create_purchase = pr.click('create_purchase')
>>> create_purchase.form.party = supplier
>>> create_purchase.execute('start')
>>> pr.state
@@ -121,16 +120,14 @@
Handle the exception::
- >>> handle_exception = Wizard(
- ... 'purchase.request.handle.purchase.cancellation', [pr])
+ >>> handle_exception = pr.click('handle_purchase_cancellation_exception')
>>> handle_exception.execute('reset')
>>> pr.state
'draft'
Recreate a purchase and cancel it again::
- >>> create_purchase = Wizard('purchase.request.create_purchase',
- ... [pr])
+ >>> create_purchase = pr.click('create_purchase')
>>> pr.state
'purchased'
>>> (purchase,), = create_purchase.actions
@@ -141,8 +138,7 @@
Handle again the exception::
- >>> handle_exception = Wizard(
- ... 'purchase.request.handle.purchase.cancellation', [pr])
+ >>> handle_exception = pr.click('handle_purchase_cancellation_exception')
>>> handle_exception.execute('cancel_request')
>>> pr.state
'cancelled'
@@ -174,7 +170,7 @@
Create the purchase with a unique line::
- >>> create_purchase = Wizard('purchase.request.create_purchase', prs)
+ >>> create_purchase = PurchaseRequest.click(prs, 'create_purchase')
>>> create_purchase.form.party = supplier
>>> create_purchase.execute('start')
>>> pr.state
@@ -203,7 +199,7 @@
Create the purchase without product::
- >>> create_purchase = Wizard('purchase.request.create_purchase', [pr])
+ >>> create_purchase = pr.click('create_purchase')
>>> create_purchase.form.party = supplier
>>> create_purchase.execute('start')
>>> pr.state
diff -r 067b9d88952e -r 30e74b413c43
modules/purchase_request/view/purchase_request_tree.xml
--- a/modules/purchase_request/view/purchase_request_tree.xml Sun Mar 17
12:27:03 2024 +0100
+++ b/modules/purchase_request/view/purchase_request_tree.xml Wed Nov 19
12:22:17 2025 +0100
@@ -11,4 +11,5 @@
<field name="purchase_date"/>
<field name="stock_level" symbol="default_uom" optional="0"/>
<field name="state"/>
+ <button name="create_purchase" multiple="1"/>
</tree>