details: https://code.tryton.org/tryton/commit/d93ebc421436
branch: 7.4
user: Cédric Krier <[email protected]>
date: Mon Nov 17 12:26:57 2025 +0100
description:
Enforce access check in export_data
As the method is using instances to construct the exported data, the
access
must be checked explicitly.
Closes #14366
(grafted from 4e3e875a295e533244d0f28c1cf2efe5187489ba)
diffstat:
trytond/CHANGELOG | 1 +
trytond/trytond/model/modelstorage.py | 23 +++++++++++
trytond/trytond/tests/test_exportdata.py | 66 ++++++++++++++++++++++++++++++++
3 files changed, 90 insertions(+), 0 deletions(-)
diffs (130 lines):
diff -r 8e08b28362c1 -r d93ebc421436 trytond/CHANGELOG
--- a/trytond/CHANGELOG Wed Nov 12 14:56:34 2025 +0100
+++ b/trytond/CHANGELOG Mon Nov 17 12:26:57 2025 +0100
@@ -1,3 +1,4 @@
+* Enforce access check in export_data (issue14366)
* Include the traceback only in RPC responses in development mode (issue14354)
* Enforce access check in HTML editor route (issue14364)
diff -r 8e08b28362c1 -r d93ebc421436 trytond/trytond/model/modelstorage.py
--- a/trytond/trytond/model/modelstorage.py Wed Nov 12 14:56:34 2025 +0100
+++ b/trytond/trytond/model/modelstorage.py Mon Nov 17 12:26:57 2025 +0100
@@ -730,6 +730,11 @@
def __export_row(self, fields_names):
pool = Pool()
+ ModelAccess = pool.get('ir.model.access')
+ ModelFieldAccess = pool.get('ir.model.field.access')
+ Rule = pool.get('ir.rule')
+ IrModel = pool.get('ir.model')
+
lines = []
data = ['' for x in range(len(fields_names))]
done = []
@@ -751,6 +756,24 @@
field_name, language = field_name.split(':lang=')
eModel = pool.get(value.__name__)
field = eModel._fields[field_name]
+
+ ModelAccess.check(eModel.__name__, 'read')
+ ModelFieldAccess.check(eModel.__name__, [field_name], 'read')
+ domain = Rule.domain_get(eModel.__name__, mode='read')
+ if (domain
+ and not eval_domain(
+ domain, EvalEnvironment(value, eModel))):
+ clause, clause_global = Rule.get(
+ eModel.__name__, mode='read')
+ rules = []
+ rules.extend(clause.keys())
+ rules.extend(clause_global.keys())
+ raise AccessError(gettext(
+ 'ir.msg_read_rule_error',
+ ids=str(value.id),
+ model=IrModel.get_name(eModel.__name__),
+ rules='\n'.join(r.name for r in rules)))
+
if field.states and 'invisible' in field.states:
invisible = _record_eval_pyson(
value, field.states['invisible'])
diff -r 8e08b28362c1 -r d93ebc421436 trytond/trytond/tests/test_exportdata.py
--- a/trytond/trytond/tests/test_exportdata.py Wed Nov 12 14:56:34 2025 +0100
+++ b/trytond/trytond/tests/test_exportdata.py Mon Nov 17 12:26:57 2025 +0100
@@ -2,8 +2,10 @@
# This file is part of Tryton. The COPYRIGHT file at the top level of
# this repository contains the full copyright notices and license terms.
import datetime
+import json
from decimal import Decimal
+from trytond.model.exceptions import AccessError
from trytond.pool import Pool
from trytond.tests.test_tryton import (
TestCase, activate_module, with_transaction)
@@ -527,3 +529,67 @@
ExportData.export_data_domain(
[('boolean', '=', True)], ['boolean'], header=True),
[["Boolean"], [True]])
+
+ @with_transaction(context={'_check_access': True})
+ def test_model_access(self):
+ "Test export without model access"
+ pool = Pool()
+ ExportData = pool.get('test.export_data')
+ ModelAccess = pool.get('ir.model.access')
+
+ export, = ExportData.create([{
+ 'char': "Test",
+ }])
+ ModelAccess.create([{
+ 'model': ExportData.__name__,
+ 'perm_read': False,
+ }])
+
+ with self.assertRaises(AccessError):
+ ExportData.export_data([export], ['char'])
+
+ @with_transaction(context={'_check_access': True})
+ def test_field_access(self):
+ "Test export without field access"
+ pool = Pool()
+ ExportData = pool.get('test.export_data')
+ FieldAccess = pool.get('ir.model.field.access')
+
+ export, = ExportData.create([{
+ 'char': "Test",
+ }])
+ FieldAccess.create([{
+ 'model': ExportData.__name__,
+ 'field': 'char',
+ 'perm_read': False,
+ }])
+
+ with self.assertRaises(AccessError):
+ ExportData.export_data([export], ['char'])
+
+ @with_transaction(context={'_check_access': True})
+ def test_rule_access(self):
+ "Test export with rule access"
+ pool = Pool()
+ ExportData = pool.get('test.export_data')
+ RuleGroup = pool.get('ir.rule.group')
+
+ export1, export2 = ExportData.create([{
+ 'char': "foo",
+ }, {
+ 'char': "bar",
+ }])
+ RuleGroup.create([{
+ 'name': "Test",
+ 'model': ExportData.__name__,
+ 'global_p': True,
+ 'perm_read': True,
+ 'rules': [('create', [{
+ 'domain': json.dumps(
+ [('char', '!=', 'bar')]),
+ }])],
+ }])
+
+ ExportData.export_data([export1], ['char'])
+ with self.assertRaises(AccessError):
+ ExportData.export_data([export2], ['char'])