details: https://code.tryton.org/tryton/commit/3c72aa753b4e
branch: 7.4
user: Cédric Krier <[email protected]>
date: Mon Nov 17 10:28:49 2025 +0100
description:
Enforce access check in HTML editor route
Use .read and .write instead of .browse and .save when editing field
via the
HTML editor.
Closes #14364
(grafted from 1103361fdaf6d9da12fe6455d871a4eba089d768)
diffstat:
trytond/CHANGELOG | 1 +
trytond/trytond/ir/routes.py | 7 ++++---
2 files changed, 5 insertions(+), 3 deletions(-)
diffs (44 lines):
diff -r 7eb16e74d5af -r 3c72aa753b4e trytond/CHANGELOG
--- a/trytond/CHANGELOG Mon Nov 03 11:16:05 2025 +0100
+++ b/trytond/CHANGELOG Mon Nov 17 10:28:49 2025 +0100
@@ -1,3 +1,4 @@
+* Enforce access check in HTML editor route (issue14364)
Version 7.4.20 - 2025-11-02
---------------------------
diff -r 7eb16e74d5af -r 3c72aa753b4e trytond/trytond/ir/routes.py
--- a/trytond/trytond/ir/routes.py Mon Nov 03 11:16:05 2025 +0100
+++ b/trytond/trytond/ir/routes.py Mon Nov 17 10:28:49 2025 +0100
@@ -56,20 +56,21 @@
with transaction.set_context(language=language):
Model = pool.get(model)
record = Model(record)
+ values = Model.read([record.id], ['rec_name', field.name])[0]
status = HTTPStatus.OK
error = ''
if request.method == 'POST':
setattr(record, field.name, request.form['text'])
if request.form['_csrf_token'] == get_token(record):
- record.save()
+ Model.write([record], {field.name: request.form['text']})
return redirect(request.url)
else:
status = HTTPStatus.BAD_REQUEST
error = gettext('ir.msg_html_editor_save_fail')
csrf_token = get_token(record)
- text = getattr(record, field.name) or ''
+ text = values[field.name] or ''
if isinstance(text, bytes):
try:
text = text.decode('utf-8')
@@ -80,7 +81,7 @@
abort(HTTPStatus.BAD_REQUEST)
title = '%(model)s "%(name)s" %(field)s - %(title)s' % {
'model': field.model_ref.name,
- 'name': record.rec_name,
+ 'name': values['rec_name'],
'field': field.field_description,
'title': request.args.get('title', "Tryton"),
}