details: https://code.tryton.org/tryton/commit/f2293673b1b3
branch: default
user: Cédric Krier <[email protected]>
date: Thu Dec 18 15:18:53 2025 +0100
description:
Compare HTTP status code to HTTPStatus enum
diffstat:
modules/edocument_peppol_peppyrus/edocument.py | 5 ++-
modules/stock_package_shipping_sendcloud/carrier.py | 2 +-
trytond/trytond/tests/test_routes.py | 28 ++++++++++----------
3 files changed, 18 insertions(+), 17 deletions(-)
diffs (154 lines):
diff -r a329bddd2e13 -r f2293673b1b3
modules/edocument_peppol_peppyrus/edocument.py
--- a/modules/edocument_peppol_peppyrus/edocument.py Tue Dec 16 17:28:32
2025 +0100
+++ b/modules/edocument_peppol_peppyrus/edocument.py Thu Dec 18 15:18:53
2025 +0100
@@ -13,6 +13,7 @@
from trytond.model import fields
from trytond.modules.edocument_peppol.exceptions import PeppolServiceError
from trytond.pool import Pool, PoolMeta
+from trytond.protocols.wrappers import HTTPStatus
from trytond.pyson import Eval
from trytond.transaction import Transaction
@@ -86,7 +87,7 @@
'Accept': 'application/json',
'X-Api-Key': self.peppyrus_api_key,
})
- if response.status_code == 422:
+ if response.status_code == HTTPStatus.UNPROCESSABLE_CONTENT:
raise PeppolServiceError(response.json())
response.raise_for_status()
return response.json()['id']
@@ -193,7 +194,7 @@
'Accept': 'application/json',
'X-Api-Key': api_key,
})
- if response.status_code != 404:
+ if response.status_code != HTTPStatus.NOT_FOUND:
response.raise_for_status()
except Exception:
if not silent:
diff -r a329bddd2e13 -r f2293673b1b3
modules/stock_package_shipping_sendcloud/carrier.py
--- a/modules/stock_package_shipping_sendcloud/carrier.py Tue Dec 16
17:28:32 2025 +0100
+++ b/modules/stock_package_shipping_sendcloud/carrier.py Thu Dec 18
15:18:53 2025 +0100
@@ -178,7 +178,7 @@
response = requests.post(
SENDCLOUD_API_URL + 'parcels', json={'parcels': parcels},
auth=self.auth, timeout=timeout, headers=HEADERS)
- if response.status_code == 400:
+ if response.status_code == HTTPStatus.BAD_REQUEST:
msg = response.json()['error']['message']
raise requests.HTTPError(msg, response=response)
response.raise_for_status()
diff -r a329bddd2e13 -r f2293673b1b3 trytond/trytond/tests/test_routes.py
--- a/trytond/trytond/tests/test_routes.py Tue Dec 16 17:28:32 2025 +0100
+++ b/trytond/trytond/tests/test_routes.py Thu Dec 18 15:18:53 2025 +0100
@@ -5,7 +5,7 @@
import json
from trytond.pool import Pool
-from trytond.protocols.wrappers import Response
+from trytond.protocols.wrappers import HTTPStatus, Response
from trytond.tests.test_tryton import (
DB_NAME, Client, TestCase, activate_module, drop_db)
from trytond.transaction import Transaction
@@ -50,7 +50,7 @@
response = c.get(self.data_url('res.user'), headers=self.auth_headers)
- self.assertEqual(response.status_code, 200)
+ self.assertEqual(response.status_code, HTTPStatus.OK)
self.assertEqual(response.data, b'\r\n\r\n')
def test_data_one_field(self):
@@ -61,7 +61,7 @@
self.data_url('res.user'), headers=self.auth_headers,
query_string=[('f', 'name')])
- self.assertEqual(response.status_code, 200)
+ self.assertEqual(response.status_code, HTTPStatus.OK)
self.assertEqual(response.data, b'Nom\r\nAdministrator\r\n')
def test_data_multiple_fields(self):
@@ -72,7 +72,7 @@
self.data_url('res.user'), headers=self.auth_headers,
query_string=[('f', 'name'), ('f', 'login')])
- self.assertEqual(response.status_code, 200)
+ self.assertEqual(response.status_code, HTTPStatus.OK)
self.assertEqual(
response.data, b'Nom,Identifiant\r\nAdministrator,admin\r\n')
@@ -88,7 +88,7 @@
('d', json.dumps([('code', '=', 'fr')])),
])
- self.assertEqual(response.status_code, 200)
+ self.assertEqual(response.status_code, HTTPStatus.OK)
self.assertEqual(response.data, 'Nom\r\nFrançais\r\n'.encode('utf-8'))
def test_data_size(self):
@@ -102,7 +102,7 @@
('s', 5),
])
- self.assertEqual(response.status_code, 200)
+ self.assertEqual(response.status_code, HTTPStatus.OK)
self.assertEqual(len(response.data.splitlines()), 5 + 1)
def test_data_page(self):
@@ -124,8 +124,8 @@
('p', 1)
])
- self.assertEqual(response0.status_code, 200)
- self.assertEqual(response1.status_code, 200)
+ self.assertEqual(response0.status_code, HTTPStatus.OK)
+ self.assertEqual(response1.status_code, HTTPStatus.OK)
self.assertNotEqual(response0.data, response1.data)
def test_data_encoding(self):
@@ -141,7 +141,7 @@
('enc', 'latin1'),
])
- self.assertEqual(response.status_code, 200)
+ self.assertEqual(response.status_code, HTTPStatus.OK)
self.assertEqual(
response.data, 'Nom\r\nFrançais\r\n'.encode('latin1'))
@@ -153,7 +153,7 @@
self.data_url('res.user'), headers=self.auth_headers,
query_string=[('f', 'name'), ('f', 'login'), ('dl', '|')])
- self.assertEqual(response.status_code, 200)
+ self.assertEqual(response.status_code, HTTPStatus.OK)
self.assertEqual(
response.data, b'Nom|Identifiant\r\nAdministrator|admin\r\n')
@@ -166,7 +166,7 @@
query_string=[
('f', 'name'), ('f', 'login'), ('dl', 'n'), ('qc', '*')])
- self.assertEqual(response.status_code, 200)
+ self.assertEqual(response.status_code, HTTPStatus.OK)
self.assertEqual(
response.data,
b'Nomn*Identifiant*\r\n*Administrator*n*admin*\r\n')
@@ -179,7 +179,7 @@
self.data_url('res.user'), headers=self.auth_headers,
query_string=[('f', 'name'), ('h', 0)])
- self.assertEqual(response.status_code, 200)
+ self.assertEqual(response.status_code, HTTPStatus.OK)
self.assertEqual(response.data, b'Administrator\r\n')
def test_data_locale_format(self):
@@ -193,6 +193,6 @@
self.data_url('res.user'), headers=self.auth_headers,
query_string=[('f', 'create_date'), ('loc', 1)])
- self.assertEqual(response_std.status_code, 200)
- self.assertEqual(response_locale.status_code, 200)
+ self.assertEqual(response_std.status_code, HTTPStatus.OK)
+ self.assertEqual(response_locale.status_code, HTTPStatus.OK)
self.assertNotEqual(response_std.data, response_locale.data)
