details: https://code.tryton.org/tryton/commit/be2999489bb5
branch: 7.8
user: Cédric Krier <[email protected]>
date: Fri Jan 23 09:57:31 2026 +0100
description:
Do not include removed records in the search domain of One2Many
Adding an OR-ed clause prevents the domain inversion to set any unique
values
when creating a record from the search window.
The removed records can be re-add with the undelete button instead.
Closes #14540
(grafted from 4a30450c54bd6d75614fa1cfffeb7498a669cbcf)
diffstat:
sao/src/model.js | 5 -----
sao/src/view/form.js | 4 ----
tryton/tryton/gui/window/view_form/model/field.py | 3 ---
tryton/tryton/gui/window/view_form/view/form_gtk/one2many.py | 4 ----
4 files changed, 0 insertions(+), 16 deletions(-)
diffs (70 lines):
diff -r b5f7ee546771 -r be2999489bb5 sao/src/model.js
--- a/sao/src/model.js Thu Jan 22 17:28:16 2026 +0100
+++ b/sao/src/model.js Fri Jan 23 09:57:31 2026 +0100
@@ -2637,11 +2637,6 @@
}
return result;
},
- get_removed_ids: function(record) {
- return record._values[this.name].record_removed.map(function(r) {
- return r.id;
- });
- },
get_domain: function(record) {
var domains = this.get_domains(record);
var attr_domain = domains[1];
diff -r b5f7ee546771 -r be2999489bb5 sao/src/view/form.js
--- a/sao/src/view/form.js Thu Jan 22 17:28:16 2026 +0100
+++ b/sao/src/view/form.js Fri Jan 23 09:57:31 2026 +0100
@@ -3692,8 +3692,6 @@
if (existing_ids.length) {
domain = [domain, ['id', 'not in', existing_ids]];
}
- var removed_ids = this.field.get_removed_ids(this.record);
- domain = ['OR', domain, ['id', 'in', removed_ids]];
var text = this.wid_text.val();
if (this._popup) {
@@ -3986,8 +3984,6 @@
if (existing_ids.length) {
domain = [domain, ['id', 'not in', existing_ids]];
}
- var removed_ids = this.field.get_removed_ids(this.record);
- domain = ['OR', domain, ['id', 'in', removed_ids]];
return Sao.common.update_completion(
this.wid_text, this.record, this.field, model, domain);
},
diff -r b5f7ee546771 -r be2999489bb5
tryton/tryton/gui/window/view_form/model/field.py
--- a/tryton/tryton/gui/window/view_form/model/field.py Thu Jan 22 17:28:16
2026 +0100
+++ b/tryton/tryton/gui/window/view_form/model/field.py Fri Jan 23 09:57:31
2026 +0100
@@ -931,9 +931,6 @@
self._set_default_value(record)
super().state_set(record, states=states)
- def get_removed_ids(self, record):
- return [x.id for x in record.value[self.name].record_removed]
-
def domain_get(self, record):
screen_domain, attr_domain = self.domains_get(record)
# Forget screen_domain because it only means at least one record
diff -r b5f7ee546771 -r be2999489bb5
tryton/tryton/gui/window/view_form/view/form_gtk/one2many.py
--- a/tryton/tryton/gui/window/view_form/view/form_gtk/one2many.py Thu Jan
22 17:28:16 2026 +0100
+++ b/tryton/tryton/gui/window/view_form/view/form_gtk/one2many.py Fri Jan
23 09:57:31 2026 +0100
@@ -512,8 +512,6 @@
existing_ids = self.field.get_eval(self.record)
if existing_ids:
domain = [domain, ('id', 'not in', existing_ids)]
- removed_ids = self.field.get_removed_ids(self.record)
- domain = ['OR', domain, ('id', 'in', removed_ids)]
text = self.wid_text.get_text()
if self._popup:
@@ -621,8 +619,6 @@
existing_ids = self.field.get_eval(self.record)
if existing_ids:
domain = [domain, ('id', 'not in', existing_ids)]
- removed_ids = self.field.get_removed_ids(self.record)
- domain = ['OR', domain, ('id', 'in', removed_ids)]
update_completion(self.wid_text, self.record, self.field, model,
domain=domain)
