details: https://code.tryton.org/tryton/commit/c3be98d53656
branch: 8.0
user: Cédric Krier <[email protected]>
date: Tue Jul 21 17:32:21 2026 +0200
description:
Use dict.get instead of getattr to retrieve user errors from Shopify
request
The GraphQL library returns dict instead of object.
Closes #14964
(grafted from 4ec0ec9f0ae00251716f1e731c1d936857151fd9)
diffstat:
modules/web_shop_shopify/tests/tools.py | 2 +-
modules/web_shop_shopify/web.py | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diffs (24 lines):
diff -r 19536106fede -r c3be98d53656 modules/web_shop_shopify/tests/tools.py
--- a/modules/web_shop_shopify/tests/tools.py Wed Jul 15 18:07:22 2026 +0200
+++ b/modules/web_shop_shopify/tests/tools.py Tue Jul 21 17:32:21 2026 +0200
@@ -41,7 +41,7 @@
names = user_errors.split('.')
errors = result.data
for name in names:
- errors = getattr(errors, name, None)
+ errors = errors.get(name, None)
if errors is None:
break
if errors:
diff -r 19536106fede -r c3be98d53656 modules/web_shop_shopify/web.py
--- a/modules/web_shop_shopify/web.py Wed Jul 15 18:07:22 2026 +0200
+++ b/modules/web_shop_shopify/web.py Tue Jul 21 17:32:21 2026 +0200
@@ -331,7 +331,7 @@
names = user_errors.split('.')
errors = result.data
for name in names:
- errors = getattr(errors, name, None)
+ errors = errors.get(name, None)
if errors is None:
break
if errors: