tqchen commented on issue #4346: [Runtime] Make ADTObject POD container type URL: https://github.com/apache/incubator-tvm/pull/4346#issuecomment-555227668 Comments about Init function design, we want something that is minimum(can be reused by Vector style sub-class and Tuple-style sub-classes), while not interfering too much with low-level content. One possible such interface could looks like http://www.cplusplus.com/reference/vector/vector/emplace_back/ ```c++ protected: template <typename... Args> void EmplaceInit(size_t idx, Args&&... args); ``` Which EmplaceInit initializes elements at location idx(given the that idx has not been initialized before. This function can then be used by various other initializer/push_back functions(which we can debate whether they should be in the sub-class or base).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
