tqchen commented on issue #4346: [Runtime] Make ADTObject POD container type URL: https://github.com/apache/incubator-tvm/pull/4346#issuecomment-557298050 @wweic Some further comments. I think we don't have to implement push_back and emplace_back at the base level as ADT are immutable, we just need to have easy tools to initialize an element(EmplaceInit) and can build the rest of the features in the sub-class on top of the base class. Thanks for the changes so far. Base data structure is a fundamental piece for the system, so we have to be extra picky in reviewing the code, but it is also rewarding and fun to build.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
