tqchen commented on issue #4304: [RFC] Benchmark Performance Log Format WIP URL: https://github.com/apache/incubator-tvm/issues/4304#issuecomment-557725023 Some further comments wrt to the recently hardware_config change - I still think it is important to keep the ```runtime_config```, which includes fields like ```num_cpu_threads```. Now that software config mainly specifies the environment dependencies, maybe it makes sense to move num_cpu_threads into runtime_config, as it is something that can be specified through runtime env variable. - It is important to keep ```hardware_config``` simple, because this is the key that we use to compare among targets. - docker_tag should not be a required field, as not all experiments have to ran through a docker container. I would even consider move docker_tag as an optional field of engine_config, as it is something related to the software engine.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
