tqchen commented on issue #4304: [RFC] Benchmark Performance Log Format WIP URL: https://github.com/apache/incubator-tvm/issues/4304#issuecomment-557728437 I think docker_tag under metadata as long as it is optional (the RFC said the field was required which confuses me). There are certainly cases when people want to limit the number of threads, e.g. use only the little cores on the phone to save power. While these could have been a nested field in the hardware_config, it makes the field quite complicated. One of the key property of we should push for the log format is its simplicity. The three fields(engine, workload, hardware_config) are three fields that the user will mostly visit. e.g. ask how can "tvm" do for "resnet-18" on "rasp3b" Of course the information was incomplete, but the in many cases the three fields already gives a quite complete picture, assuming the default implied target and maximum usage of the resources. Given that number of threads and other runtime configurations(thread pool setups) are indeed runtime properties that was different from software_config. I think we should keep the original runtime_config field for these information.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
