optima2005 commented on a change in pull request #4551: [Relay] add max_pool3d
in relay and TF converter
URL: https://github.com/apache/incubator-tvm/pull/4551#discussion_r360630661
##########
File path: tests/python/frontend/tensorflow/test_forward.py
##########
@@ -237,16 +237,43 @@ def _test_pooling_iteration(input_shape, **kwargs):
def _test_pooling(input_shape, **kwargs):
_test_pooling_iteration(input_shape, **kwargs)
- if is_gpu_available() and (len(input_shape) == 4):
- input_shape = [input_shape[ii] for ii in (0, 3, 1, 2)]
- kwargs['data_format'] = 'NCHW'
- _test_pooling_iteration(input_shape, **kwargs)
+ if is_gpu_available():
+ if len(input_shape) == 4:
+ input_shape = [input_shape[ii] for ii in (0, 3, 1, 2)]
+ kwargs['data_format'] = 'NCHW'
+ _test_pooling_iteration(input_shape, **kwargs)
+ elif len(input_shape) == 5:
+ input_shape = [input_shape[ii] for ii in (0, 4, 1, 2, 3)]
+ kwargs['data_format'] = 'NCDHW'
+ _test_pooling_iteration(input_shape, **kwargs)
def test_forward_pooling():
""" Pooling """
+ # TensorFlow only supports NDHWC for max_pool3d on CPU
+ for pool_type in ['MAX', 'AVG']:
+
+ _test_pooling(input_shape=[1, 3, 32, 32, 32],
+ window_shape=[2, 2, 2],
+ padding='VALID',
+ pooling_type=pool_type,
+ dilation_rate=[1, 1, 1],
+ strides=[2, 2, 2])
+
+ _test_pooling(input_shape=[1, 3, 32, 32, 32],
+ window_shape=[1, 1, 1],
+ padding='SAME',
+ pooling_type=pool_type,
+ dilation_rate=[1, 1, 1],
+ strides=[1, 1, 1])
+
+ _test_pooling(input_shape=[1, 3, 32, 32, 32],
+ window_shape=[2, 2, 2],
+ padding='SAME',
+ pooling_type=pool_type,
+ dilation_rate=[1, 1, 1],
+ strides=[2, 2, 2])
Review comment:
Need add "NDHWC" layout cases.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
