masahi commented on a change in pull request #4551: [Relay] add max_pool3d in
relay and TF converter
URL: https://github.com/apache/incubator-tvm/pull/4551#discussion_r360670805
##########
File path: tests/python/relay/test_op_level2.py
##########
@@ -532,6 +532,72 @@ def test_pool2d():
_test_global_pool2d(relay.nn.global_avg_pool2d, np.mean)
+def test_pool3d():
+
+ def _test_pool3d_baseline(np_data, in_shape, kernal, strides, padding,
Review comment:
move this function to topi/python/topi/testing and rename it to pool3d_python
Also use that function to replace the hard coded one in the topi test
https://github.com/apache/incubator-tvm/blob/master/topi/tests/python/test_topi_pooling.py#L298-L316
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
