wweic commented on a change in pull request #4581: [REFACTOR][RUNTIME] Update
NDArray use the Unified Object System
URL: https://github.com/apache/incubator-tvm/pull/4581#discussion_r361599592
##########
File path: include/tvm/runtime/ndarray.h
##########
@@ -259,42 +211,27 @@ class NDArray::Container {
* (e.g. reference to original memory when creating views).
*/
void* manager_ctx{nullptr};
- /*!
- * \brief Customized deleter
- *
- * \note The customized deleter is helpful to enable
- * different ways of memory allocator that are not
- * currently defined by the system.
- */
- void (*deleter)(Container* self) = nullptr;
protected:
- friend class NDArray;
- friend class TVMPODValue_;
- friend class TVMArgValue;
- friend class TVMRetValue;
- friend class RPCWrappedFunc;
- /*!
- * \brief Type flag used to indicate subclass.
- * Default value 0 means normal NDArray::Conatainer.
- *
- * We can extend a more specialized NDArray::Container
- * and use the array_type_code_ to indicate
- * the specific array subclass.
- */
- int32_t array_type_code_{0};
- /*! \brief The internal reference counter */
- std::atomic<int> ref_counter_{0};
-
/*!
* \brief The shape container,
* can be used used for shape data.
*/
std::vector<int64_t> shape_;
+};
+/*!
+ * \brief Object container class taht backs NDArray.
Review comment:
```suggestion
* \brief Object container class that backs NDArray.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
