wweic commented on a change in pull request #4581: [REFACTOR][RUNTIME] Update
NDArray use the Unified Object System
URL: https://github.com/apache/incubator-tvm/pull/4581#discussion_r361597117
##########
File path: apps/extension/src/tvm_ext.cc
##########
@@ -65,41 +52,45 @@ class NDSubClass : public tvm::runtime::NDArray {
public:
class SubContainer : public NDArray::Container {
public:
- SubContainer(int addtional_info) :
- addtional_info_(addtional_info) {
- array_type_code_ = array_type_info<NDSubClass>::code;
- }
- static bool Is(NDArray::Container *container) {
- SubContainer *c = static_cast<SubContainer*>(container);
- return c->array_type_code_ == array_type_info<NDSubClass>::code;
+ SubContainer(int additional_info) :
Review comment:
The comment between line 47 and line 49 needs to be updated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
