zhiics commented on a change in pull request #4241: [Dynamic Shape] Add Graph 
Dispatcher
URL: https://github.com/apache/incubator-tvm/pull/4241#discussion_r362155117
 
 

 ##########
 File path: python/tvm/relay/transform.py
 ##########
 @@ -1032,3 +1032,40 @@ def visit_var(self, var):
                 else:
                     return var
         return ChangeBatchMutator().visit(func)
+
+def add_dispatch_func(mod, func_name, input_shape, dispatch_func):
 
 Review comment:
   I think we can make it a `ModulePass` can func_name can default to "main" so 
that it can be managed by pass manager. The API would look like:
   
   ```python
   AddDispatchFunc(input_shape, dispatch_func, func_name="main")
   ```
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to