zhiics commented on a change in pull request #4241: [Dynamic Shape] Add Graph 
Dispatcher
URL: https://github.com/apache/incubator-tvm/pull/4241#discussion_r362154497
 
 

 ##########
 File path: python/tvm/relay/testing/init.py
 ##########
 @@ -160,6 +160,13 @@ def create_workload(net, initializer=None, seed=0):
     for k, v in shape_dict.items():
         if k == "data":
 
 Review comment:
   can we do something like the following and document it?
   ```python
   if k == "data" or any(isinstance(d, tvm.expr.Var) for d in v.shape):
   ```
   so that line 163~169 can be removed?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to