comaniac edited a comment on issue #4637: [RUNTIME][DSO] Improve 
TVMBackendPackedCFunc to allow return val
URL: https://github.com/apache/incubator-tvm/pull/4637#issuecomment-571367737
 
 
   Thanks for the PR. The macros are indeed helpful for customized runtimes and 
can reduce the developer efforts. I'll file another PR to make use of them in 
[this 
example](https://github.com/apache/incubator-tvm/blob/master/src/runtime/contrib/example_ext_runtime/example_ext_runtime.cc)
 after this one have been merged. 
   
   The change are LGTM. Since I may not be aware of some concerns in backend 
APIs, I am leaving it for others.
   
   btw, you may need to fix the failure cases in CI.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to