zhiics commented on a change in pull request #4637: [RUNTIME][DSO] Improve
TVMBackendPackedCFunc to allow return val
URL: https://github.com/apache/incubator-tvm/pull/4637#discussion_r363602628
##########
File path: include/tvm/runtime/packed_func.h
##########
@@ -877,6 +894,104 @@ class TVMRetValue : public TVMPODValue_ {
}
};
+/*!
+ * \brief Export a function with the PackedFunc signature
+ * as a PackedFunc that can loaded by LibraryModule.
+ *
+ * \param ExportName The symbol name to be exported.
+ * \param Function The function with PackedFunc signature.
+ * \sa PackedFunc
+ *
+ * \code
+ *
+ * void AddOne_(TVMArgs args, TVMRetValue* rv) {
+ * int value = args[0];
+ * *rv = value + 1;
+ * }
+ * // Expose the function as "AddOne"
+ * TVM_DLL_EXPORT_PACKED_FUNC(AddOne, AddOne_);
+ *
+ * \endcode
+ */
+#define TVM_DLL_EXPORT_PACKED_FUNC(ExportName, Function) \
+ extern "C" { \
+ TVM_DLL int ExportName(TVMValue* args, \
+ int* type_code, \
+ int num_args, \
+ TVMValue* out_value, \
+ int* out_type_code) { \
+ try { \
+ ::tvm::runtime::TVMRetValue rv; \
+ Function(::tvm::runtime::TVMArgs( \
+ args, type_code, num_args), &rv); \
+ rv.MoveToCHost(out_value, out_type_code); \
+ return 0; \
+ } catch (const ::std::runtime_error& _except_) { \
+ TVMAPISetLastError(_except_.what()); \
+ return -1; \
+ } \
+ } \
+ }
+
+/*!
+ * \brief Export typed function as a PackedFunc
+ * that can loaded by LibraryModule.
Review comment:
```suggestion
* that can loaded be by LibraryModule.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
