jackwish commented on a change in pull request #4629: [QNN] Channel wise
quantization - Quantize & Requantize
URL: https://github.com/apache/incubator-tvm/pull/4629#discussion_r363591314
##########
File path: src/relay/qnn/op/requantize.cc
##########
@@ -157,16 +175,22 @@ bool RequantizeRel(const Array<Type>& types, int
num_inputs, const Attrs& attrs,
in_dtype == DataType::Int(32))
<< "Input type should be one of [int8, uint8, int32] but was " <<
in_dtype;
- // Check the types of scale and zero points.
- CHECK(IsScalarType(types[1], DataType::Float(32))); // input_scale
- CHECK(IsScalarType(types[2], DataType::Int(32))); // input_zero_point
+ const RequantizeAttrs* requantize_attrs = attrs.as<RequantizeAttrs>();
+ int axis = requantize_attrs->axis;
+ axis = (axis == -1) ? data->shape.size() - 1: axis;
+ CHECK_LE(axis, static_cast<int>(data->shape.size()))
Review comment:
Same with `quantize`, should be `CHECK_LT` here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
