jackwish commented on a change in pull request #4629: [QNN] Channel wise
quantization - Quantize & Requantize
URL: https://github.com/apache/incubator-tvm/pull/4629#discussion_r363577646
##########
File path: src/relay/pass/pattern_util.h
##########
@@ -221,29 +222,66 @@ inline bool IsScalar(const Expr& expr) {
return true;
}
+/*!
+ * \brief Check if expr is a const scalar.
+ * \param expr The expr.
+ * \return True if const scalar.
+ */
+inline bool IsConstScalar(const Expr& expr) {
+ const auto* const_expr = expr.as<ConstantNode>();
+ return const_expr && const_expr->is_scalar();
Review comment:
what about comparing `const_expr` against `nullptr`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
