shoubhik commented on a change in pull request #4629: [QNN] Channel wise
quantization - Quantize & Requantize
URL: https://github.com/apache/incubator-tvm/pull/4629#discussion_r363865764
##########
File path: src/relay/qnn/op/quantize.cc
##########
@@ -45,11 +45,16 @@ bool QuantizeRel(const Array<Type>& types,
CHECK(input_dtype == DataType::Float(32))
<< "Input type should be one of float32 but was " << input_dtype;
- // Check the types of scale and zero points.
- CHECK(IsScalarType(types[1], DataType::Float(32))); // output_scale
- CHECK(IsScalarType(types[2], DataType::Int(32))); // output_zero_point
-
const auto* quantize_attrs = attrs.as<QuantizeAttrs>();
+ int axis = quantize_attrs->axis;
+ axis = (axis == -1) ? data->shape.size() - 1: axis;
+ CHECK_LT(axis, static_cast<int>(data->shape.size()))
Review comment:
can you also add CHECK_GT to check for the other side as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
