liangfu commented on a change in pull request #4714: Mxnet parser for Qnn dialect URL: https://github.com/apache/incubator-tvm/pull/4714#discussion_r367196432
########## File path: src/relay/qnn/op/convolution.cc ########## @@ -57,7 +57,7 @@ bool QnnConv2DRel(const Array<Type>& types, int num_inputs, const Attrs& attrs, CHECK(IsScalarType(types[2], DataType::Int(32))); // input_zero_point CHECK(IsScalarType(types[3], DataType::Int(32))); // kernel_zero_point CHECK(IsScalarType(types[4], DataType::Float(32))); // input_scale - CHECK(IsScalarType(types[5], DataType::Float(32))); // kernel_scale + // AssignType(types[1], DataType::Float(32), data->shape[axis], reporter); // kernel_scale Review comment: Why are we removing type check of `types[5]` ? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
