liangfu commented on a change in pull request #4714: Mxnet parser for Qnn 
dialect
URL: https://github.com/apache/incubator-tvm/pull/4714#discussion_r367197041
 
 

 ##########
 File path: python/tvm/relay/frontend/mxnet.py
 ##########
 @@ -180,6 +190,17 @@ def _mx_conv2d(inputs, attrs):
     new_attrs["groups"] = attrs.get_int("num_group", 1)
     new_attrs["data_layout"] = data_layout
     new_attrs["kernel_layout"] = kernel_layout
+    return new_attrs
+
+def _mx_conv2d(inputs, attrs):
+    kernel_size = attrs.get_int_tuple("kernel")
+    data_layout = attrs.get_str("layout", "NCHW")
+    if len(kernel_size) != 2:
+        raise tvm.error.OpAttributeInvalid(
+            'Non 1D or 2D kernels are not supported for operator Convolution')
 
 Review comment:
   Only 2D kernels are supported.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to