yidawang commented on a change in pull request #4747: [ThreadPool] Solve ARM 
BIG.LITTLE heterogeneous multicores
URL: https://github.com/apache/incubator-tvm/pull/4747#discussion_r368708893
 
 

 ##########
 File path: src/runtime/threading_backend.cc
 ##########
 @@ -148,19 +146,36 @@ class ThreadGroup::Impl {
           CPU_SET(sorted_order_[0], &cpuset);
         }
         pthread_setaffinity_np(pthread_self(), sizeof(cpu_set_t), &cpuset);
+      } else {
 
 Review comment:
   Under current logic, if you set `TVM_BIND_MASTER_THREAD=1`, the issue fixed 
in #4344 will come back. I would suggest keeping the current way, but making 
sure binding it to the right big/small core that user sets.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to