yidawang commented on a change in pull request #4747: [ThreadPool] Solve ARM
BIG.LITTLE heterogeneous multicores
URL: https://github.com/apache/incubator-tvm/pull/4747#discussion_r368705761
##########
File path: src/runtime/threading_backend.cc
##########
@@ -133,9 +133,7 @@ class ThreadGroup::Impl {
#endif
}
if (exclude_worker0) { // master thread run task
-#if defined(__ANDROID__)
- SetFullCpuAffinity();
-#else
+#if defined(__linux__) || defined(__ANDROID__)
Review comment:
In the current setting, this is redundant given line 115. Furthermore, in
this case, I wouldn't suggest combining the two cases together.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
