FrozenGene commented on issue #4828: tflite rounding mode support URL: https://github.com/apache/incubator-tvm/pull/4828#issuecomment-582757548 Thanks @LiangHao151941 ! I haven't reviewed the code, however, I have some high level comments: 1. if we have TFLITE rounding support, we should make TFLite frontend using TFLITE rounding and we should get the bit exact result as TFLite. 2. you should also modify the `test_forward.py` for tflite, like test_qnn* related test cases, we shouldn't need `atol=1` any more ideally. 3. you could add `q_conv2d` unit testing case, we could get the same result compared with TFLite. we lack of this unit testing.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
