FrozenGene commented on a change in pull request #4828: [QNN][TFLite] TFLite
rounding mode support
URL: https://github.com/apache/incubator-tvm/pull/4828#discussion_r376237772
##########
File path: src/relay/qnn/util.cc
##########
@@ -22,13 +22,49 @@
* \brief Utility functions for QNN.
*/
+#include <limits>
+
#include "util.h"
#include "../pass/pattern_util.h"
namespace tvm {
namespace relay {
namespace qnn {
+/* \brief This function implements the rounding part of ARMv7 NEON VQRDMULH
+ * instruction. For code reuse, the multiplied tensor is directly passed in
+ * as parameter. Reference implementation:
+ *
https://github.com/google/gemmlowp/blob/2483d846ad865dd4190fe4a1a1ba2d9cfcea78e1/fixedpoint/fixedpoint.h#L337
Review comment:
What is the license of GEMMLOWP? If you understand the algorithm and the
code is written by yourself, you could remove this link so that we could avoid
the license problem.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
