FrozenGene commented on a change in pull request #4859: [LLVM] Explicit 
llvm::StringRef to std::string conversion
URL: https://github.com/apache/incubator-tvm/pull/4859#discussion_r377427382
 
 

 ##########
 File path: src/target/llvm/codegen_llvm.cc
 ##########
 @@ -88,7 +88,11 @@ void CodeGenLLVM::InitTarget(llvm::TargetMachine* tm) {
       native_vector_bits_ = 128;
     } else {
       native_vector_bits_ = 128;
+#if TVM_LLVM_VERSION >= 100
+      std::string arch_name = std::string(tm->getTargetTriple().getArchName());
 
 Review comment:
   I agree. We could only use `std::string arch_name = 
std::string(tm->getTargetTriple().getArchName());`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to