hlu1 commented on a change in pull request #4859: [LLVM] Explicit
llvm::StringRef to std::string conversion
URL: https://github.com/apache/incubator-tvm/pull/4859#discussion_r377926869
##########
File path: src/target/llvm/codegen_llvm.cc
##########
@@ -88,7 +88,7 @@ void CodeGenLLVM::InitTarget(llvm::TargetMachine* tm) {
native_vector_bits_ = 128;
} else {
native_vector_bits_ = 128;
- std::string arch_name = tm->getTargetTriple().getArchName();
+ std::string arch_name = std::string(tm->getTargetTriple().getArchName());
Review comment:
Good to know. We decided on using explicit conversion because it works for
older version of llvm as well as llvm_10.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
