zhiics commented on a change in pull request #4951: Conditions updated to cover better user scenarios URL: https://github.com/apache/incubator-tvm/pull/4951#discussion_r386056173
########## File path: tests/cpp/relay_pass_alpha_equal.cc ########## @@ -0,0 +1,87 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +#include <gtest/gtest.h> +#include <tvm/te/operation.h> +#include <tvm/relay/expr.h> +#include <tvm/relay/type.h> +#include <tvm/relay/analysis.h> +#include <tvm/relay/transform.h> Review comment: I think this gtest is for some common cases in this pass, but it doesn't really cover the change you made, right? For example, we might want to have two tests: - lhs is not an instance of `TypeNode`, but rhs is - lhs is not an instance of `ExprNode` but rhs is I think the above tests don't necessarily have to be in gtest, they could be in Python as well because most of the pass unit tests are in Python. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
