ANSHUMAN87 commented on issue #4951: Conditions updated to cover better user scenarios URL: https://github.com/apache/incubator-tvm/pull/4951#issuecomment-593109290 > can you, in tests/python/relay/test_pass_alpha_equal.py > def test_alpha_equal(x, y): > xy = alpha_equal(x, y) > yx = alpha_equal(y, x) > assert xy == yx > return xy > > and use test_alpha_equal for those tests? @MarisaKirisame : Thanks for such detailed description. I got your point from the last comment. But one of these scenarios is special. It was not possible to hit from python test cases. That is the reason i added in cpp test case. And i believe that the unit test cases should be in cpp, not in python, as the back-end implementations are in cpp. Python test cases should be used for functional tests. But that is my belief. I hope i didn't misunderstood your comment. Please help me clarify if i am mistaken. Thanks a lot!
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
