yzhliu commented on a change in pull request #5092: [PASS] dtype rewrite for
indexing variables
URL: https://github.com/apache/incubator-tvm/pull/5092#discussion_r395451093
##########
File path: src/tir/pass/unroll_loop.cc
##########
@@ -160,7 +160,9 @@ class LoopUnroller : public StmtExprMutator {
PrimExpr extent = tir::Simplify(op->extent);
const IntImmNode *v1 = extent.as<IntImmNode>();
int value = -1;
- if (v1 != nullptr) {
+ // integers that do not fit in int32_t are treated as symbolic,
+ // as it's impossible to unroll such large loops
Review comment:
should we also print a warning here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
