hzfan commented on a change in pull request #5092: [PASS] dtype rewrite for
indexing variables
URL: https://github.com/apache/incubator-tvm/pull/5092#discussion_r395721838
##########
File path: src/tir/pass/unroll_loop.cc
##########
@@ -160,7 +160,9 @@ class LoopUnroller : public StmtExprMutator {
PrimExpr extent = tir::Simplify(op->extent);
const IntImmNode *v1 = extent.as<IntImmNode>();
int value = -1;
- if (v1 != nullptr) {
+ // integers that do not fit in int32_t are treated as symbolic,
+ // as it's impossible to unroll such large loops
Review comment:
I'm not sure. A warning here may be raised for loops that are not marked as
`unroll`. So every loop with a i64 extent raises the warning here, even when
the user does not intend to unroll it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
