tqchen commented on a change in pull request #5128: [Refactor] Relay Node::make 
to constructor
URL: https://github.com/apache/incubator-tvm/pull/5128#discussion_r396177609
 
 

 ##########
 File path: include/tvm/relay/adt.h
 ##########
 @@ -91,13 +91,9 @@ class PatternVar;
 /*! \brief PatternVar container node */
 
 Review comment:
   Yes, We can allow multiple constructors as long as there is no ambiguity 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to