tqchen commented on a change in pull request #5128: [Refactor] Relay Node::make to constructor URL: https://github.com/apache/incubator-tvm/pull/5128#discussion_r396187905
########## File path: include/tvm/relay/adt.h ########## @@ -91,13 +91,9 @@ class PatternVar; /*! \brief PatternVar container node */ Review comment: I see, in this case we should simply override the default constructor to the new behavior(do not use the original constructor) by manually defining the methods. We would likely need to add copy/move constructor and operator= overloads though in this case as well. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
