junrushao commented on code in PR #15650:
URL: https://github.com/apache/tvm/pull/15650#discussion_r1311906278


##########
python/tvm/relax/frontend/nn/spec.py:
##########
@@ -322,15 +324,18 @@ def _extern_modules() -> List[Tuple[str, List[str]]]:
         # pylint: enable=protected-access
 
         params = _params()
-        effects = _effects()
+        effects = _effects() if debug else None

Review Comment:
   Let's only set `io_effect` to None if `debug` flag is off, because there 
could be other effects, for example, kv cache



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to