jwfromm commented on code in PR #15650:
URL: https://github.com/apache/tvm/pull/15650#discussion_r1312212862
##########
python/tvm/relax/frontend/nn/spec.py:
##########
@@ -322,15 +324,18 @@ def _extern_modules() -> List[Tuple[str, List[str]]]:
# pylint: enable=protected-access
params = _params()
- effects = _effects()
+ effects = _effects() if debug else None
Review Comment:
This is great feedback and makes perfect sense. I've updated the code so
that debug only turns off io effects based on your suggestion. Can you give it
another look and see if this seems reasonable to you?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
