cbalint13 commented on PR #15761: URL: https://github.com/apache/tvm/pull/15761#issuecomment-1727843914
Hi @kparzysz-quic , Thank you for the review ! > This code should be in `LLVMTargetInfo`. Could move it there? Not sure about how. These (optional) helpers can be used independently, much earlier, prior emitting or llvm lowering steps. I am looking at [LLVMTargetInfo lifetime/scope here](https://github.com/apache/tvm/blob/9613385fd0470153676a37c8420ca22219a07973/src/target/llvm/llvm_instance.h#L301) and not sure how to cope with FFI ins<->outs for any info requests. Help me with a hint/idea about. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
