jinhongyii commented on code in PR #15826:
URL: https://github.com/apache/tvm/pull/15826#discussion_r1339018616
##########
src/runtime/disco/loader.cc:
##########
@@ -60,6 +61,10 @@ class ShardLoaderObj : public Object {
const FileRecord* file;
const ParamRecord* param;
int shard_dim;
+ PackedFunc f_reorder_fp16_;
Review Comment:
Why do we need 3 different functions for different dtypes? Why can't we pass
different packed func in shard info when dtypes are differnt?
##########
src/runtime/disco/loader.cc:
##########
@@ -60,6 +61,10 @@ class ShardLoaderObj : public Object {
const FileRecord* file;
const ParamRecord* param;
int shard_dim;
+ PackedFunc f_reorder_fp16_;
Review Comment:
Can we rename to f_preprocess, because it's more general?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
