jinhongyii commented on code in PR #15826:
URL: https://github.com/apache/tvm/pull/15826#discussion_r1339039014
##########
src/runtime/disco/loader.cc:
##########
@@ -60,6 +61,10 @@ class ShardLoaderObj : public Object {
const FileRecord* file;
const ParamRecord* param;
int shard_dim;
+ PackedFunc f_reorder_fp16_;
Review Comment:
I'm thinking of future cases where we might need more kinds of preprocessing
other than reorder. If we let users pass a preprocess function's base name in
shard info, like r`eorder_qkv`, and look for corresponding dtype variant
`reorder_qkv_fp16` in IRModule automatically, it might be more flexible. If we
want to do that, we can look up preprocess func when we call `Shard` instead of
`Create`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
