slyubomirsky commented on code in PR #15878:
URL: https://github.com/apache/tvm/pull/15878#discussion_r1346694720
##########
src/relax/transform/remove_purity_checking.cc:
##########
@@ -52,6 +52,12 @@ class PurityRemover : public ExprMutator {
call->attrs, call->sinfo_args);
return VisitExpr(ret);
}
+ if (call->op == call_inplace_packed_op_) {
+ // call_inplace_packed has its own attrs so we don't pass those down
+ auto ret = Call(call->args[0], Array<Expr>(call->args.begin() + 1,
call->args.end()),
+ tvm::Attrs(), call->sinfo_args);
Review Comment:
As far as I know, we never use the attrs for `call_pure_packed`, so we could
simply drop those and combine those cases
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
