masahi commented on PR #15878: URL: https://github.com/apache/tvm/pull/15878#issuecomment-1749492432
I mean, the KV cache update operation is disguised as a pure operation in the model. So it does build and run, that's no problem. But semantically it is not quite right and I also need to return the updated cache from the model (even thought it is in-place updated) so that passes that remove unused bindings in a df block don't accidentally remove the KV cache update op. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
