ekalda commented on PR #15918: URL: https://github.com/apache/tvm/pull/15918#issuecomment-1764218268
Very interesting PR! > Introduce new `ArrayIntImm` expression for small immediate list of integer constants. Can you not use `AllocateConst`? It's a bit awkward to introduce a whole new TIR node to support a small set of intrinsics. > The `call_llvm_pure_intrin` & `call_llvm_intrin` now holds instruction `StringImm` instead of `IntImm` abstract. I like this a lot, would make the TIR much easier to reason about! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
