ekalda commented on PR #15918: URL: https://github.com/apache/tvm/pull/15918#issuecomment-1771132982
Sorry for delay on this, I was on training for two days - > * Tried to stick with `AllocateConst`, by default it does not come at a cheap: Ah oops I had quoted the [TVMScript interface](https://github.com/apache/tvm/blob/main/tests/python/unittest/test_tvmscript_roundtrip.py#L2796) there and didn't also realise all of these arguments are required. I suppose these could be made optional if this would make `AllocateConst` usable for wider range of use cases. > * Also remembered a remark regarding "the not exposed yet status" of `tir.allocate_const` at this point in the codebase. There's an [in flight patch](https://github.com/apache/tvm/pull/15300) where @Lunderberg has done a great job in integrating the `AllocateConst` into microTVM implementation (it just keeps failing the CI 🙈). Also, it seems to me that there are a few core compiler changes in this patch that are needed for the new TOPI schedules, but are in essence target independent changes that would warrant separate discussions. How do you feel about breaking this patch up into smaller patches? From eyeballing the patch, e.g. 1. Changes to `call_llvm_intrin` and `call_llvm_pure_intrin` 2. `ArrayIntImm` node 3. New TIR intrinsics 4. TOPI schedules -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
