Hzfengsy commented on code in PR #15962:
URL: https://github.com/apache/tvm/pull/15962#discussion_r1367846802
##########
tests/python/relax/test_frontend_dynamo.py:
##########
@@ -498,9 +513,7 @@ def main(
class Select2(Module):
def forward(self, input1):
- result = input1[
- torch.arange(1),
- ]
+ result = input1[torch.arange(1),]
Review Comment:
style. Keep it remain unchanged or
```suggestion
result = input1[torch.arange(1)]
```
##########
python/tvm/relax/frontend/torch/dynamo.py:
##########
@@ -35,6 +35,28 @@ def device_from_inputs(example_inputs):
return None
+def get_fake_inputs(graph_module, example_inputs):
Review Comment:
Please write type annotations and docstring for this function
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
