liquanfeng commented on code in PR #15962:
URL: https://github.com/apache/tvm/pull/15962#discussion_r1367851514
##########
python/tvm/relax/frontend/torch/dynamo.py:
##########
@@ -35,6 +35,28 @@ def device_from_inputs(example_inputs):
return None
+def get_fake_inputs(graph_module, example_inputs):
Review Comment:
Thanks for your comment. Regarding these type annotations from Torch, I
don't think it is appropriate to `import torch` at the file header solely for
adding annotations, as shown below.
https://github.com/apache/tvm/blob/1ba11f69a786f83187cd158cb03f28659649ab26/python/tvm/relax/frontend/torch/dynamo.py#L52-L55
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
