LeiWang1999 commented on code in PR #15967: URL: https://github.com/apache/tvm/pull/15967#discussion_r1369533201
########## python/tvm/testing/tir.py: ########## Review Comment: It seems `wmma_schedule` tests for rocwmma tensorize. However, the naming might be confusing when compared to nv::wmma and rocm:wmma due to their differing warp_sizes. maybe we should consider using different name for it or dynamic select warpizes when invoke this schedule? ########## python/tvm/tir/tensor_intrin/rocm.py: ########## @@ -16,12 +16,17 @@ # under the License. # pylint: disable=invalid-name,missing-function-docstring """Intrinsics for AMDGPU tensorization.""" -from tvm.script import tir as T +import re +import tvm.tir -from tvm.runtime import convert -from tvm.tir.expr import Cast, IntImm +from typing import Dict, Tuple +from typing_extensions import Literal +from tvm.script import tir as T +from tvm.tir.function import PrimFunc +from ..._ffi import register_func Review Comment: unnecessary import of `register_func` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
