malixian commented on PR #15967: URL: https://github.com/apache/tvm/pull/15967#issuecomment-1776553143
> Overall, the code looks good to me. However, as I pointed out in the previous PR, the codegen_hip has a significant amount of duplicated code from codegen_cuda. There must exist a more appropriate way to organize it, that why I hesitated to push the code.. I believe that the high similarity between hip and cuda allows most of the code to reuse cuda's code generation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
